This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Update milli (v0.3.1) with filterable attributes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
reviewed
Jun 3, 2021
| @@ -273,15 +273,15 @@ impl Matcher for HashSet<String> { | |||
|
|
|||
| impl Matcher for MatchingWords { | |||
| fn matches(&self, w: &str) -> bool { | |||
| self.matches(w) | |||
| self.matching_bytes(w).is_some() | |||
There was a problem hiding this comment.
This must be handled by the highlighter at some point.
Kerollmops
reviewed
Jun 3, 2021
Kerollmops
reviewed
Jun 3, 2021
Kerollmops
reviewed
Jun 3, 2021
curquiza
changed the title
curquiza
force-pushed
the
update-milli-0.3.0
branch
from
c09b492 to
c4e82ef
Compare
curquiza
changed the title
|
@curquiza can you rebase please? |
curquiza
force-pushed
the
update-milli-0.3.0
branch
from
7724ead to
9996c59
Compare
|
@MarinPostma done! |
|
bors merge |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187 and #70
Also fixes #195