This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
dumps v2 #191
Merged
dumps v2 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
suggested changes
May 31, 2021
| @@ -87,6 +87,28 @@ impl Settings<Checked> { | |||
| _kind: PhantomData, | |||
| } | |||
| } | |||
|
|
|||
| pub fn into_unchecked(self) -> Settings<Unchecked> { | |||
| let Self { | |||
There was a problem hiding this comment.
that was the least amount of effort for me and my vim 😆
Comment on lines
+51
to
+62
| macro_rules! internal_error { | ||
| ($($other:path), *) => { | ||
| $( | ||
| impl From<$other> for UuidResolverError { | ||
| fn from(other: $other) -> Self { | ||
| Self::Internal(other.to_string()) | ||
| } | ||
| } | ||
| )* | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Why do we copy-paste this code in every actor instead of defining once for everyone and call it everywhere?
There was a problem hiding this comment.
because it's a bit of a workaround for now, it gets things done until I work on error handling
Co-authored-by: Irevoire <tamo@meilisearch.com>
irevoire
approved these changes
Jun 1, 2021
|
bors try |
|
bors merge |
tryBuild succeeded: |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.