This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Fix CORS authentication issue #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
fix-cors-authentication
branch
from
6fb9a95 to
e9ce680
Compare
MarinPostma
force-pushed
the
fix-cors-authentication
branch
from
e9ce680 to
78217bc
Compare
|
adding reviews from @bidoubiwa since she found the bug, and @mdubus since she knows more about CORS than I :) |
bidoubiwa
approved these changes
Apr 30, 2021
mdubus
approved these changes
May 3, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was due to the middleware returning an error, instead of a response containing the error.
close #110