Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

put mini-dashboard in out-dir #161

Merged
merged 1 commit into from
Apr 27, 2021
Merged

put mini-dashboard in out-dir #161

merged 1 commit into from
Apr 27, 2021

Conversation

MarinPostma
Copy link
Contributor

This PR puts the mini-dashboard during build in the OUT_DIR specified by cargo. This allow the mini-dashboard artifacts to be cleaned when cargo clean is ran, and not pollute the working directory with unwanted files.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌

@MarinPostma
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 27, 2021

Build succeeded:

@bors bors bot merged commit d34d7cb into main Apr 27, 2021
@bors bors bot deleted the change-mini-dashboard-dir branch April 27, 2021 07:49
Comment on lines -8 to -9
/meilisearch-http/mini-dashboard
/meilisearch-http/.mini-dashboard.sha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I was going to ask to remove these lines, really nice :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants