This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
integrate mini dashboard #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
integrate-mini-dashboard
branch
from
77cf1d1 to
6af769a
Compare
Kerollmops
suggested changes
Apr 22, 2021
MarinPostma
force-pushed
the
integrate-mini-dashboard
branch
from
41d600d to
1a838be
Compare
Kerollmops
suggested changes
Apr 22, 2021
MarinPostma
force-pushed
the
integrate-mini-dashboard
branch
2 times, most recently
from
4bbee4a to
f06f367
Compare
MarinPostma
force-pushed
the
integrate-mini-dashboard
branch
from
f06f367 to
c2461e5
Compare
Kerollmops
suggested changes
Apr 26, 2021
curquiza
previously approved these changes
Apr 26, 2021
Kerollmops
previously approved these changes
Apr 26, 2021
MarinPostma
force-pushed
the
integrate-mini-dashboard
branch
from
6a7f4eb to
e434b7d
Compare
MarinPostma
force-pushed
the
integrate-mini-dashboard
branch
from
e434b7d to
77481d7
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrate the mini dashboard to transplant.
It adds a build feature
mini-dashboardto statically add the mini-dashboard to the MeiliSearch binary. The mini-dashboard build feature is enabled by default and can be disabled by building MeiliSearch withcargo build --no-default-features.meilisearch-http/mini-dashboardmini-dashboardfeature is enabledclose #87
Shasum check and build optimizations.
In order to make sure that the right bundle for the mini-dashboard is downloaded, its shasum is computed and compared to the one specified in the
Cargo.toml. If the shasums match, them the shasum is written to the.mini-dashboard.sha1file for later comparison. On subsequent builds, the build script will check that both the mini-dashboard assets and the shasum file are found and that the shasum file content matches the one from the toml file. It will only preform a re-generation on the static dashboard files if it finds that either the dashboard is not present where it expects it to be, or if it finds out that it is outdated, by comparing the shasums.Notes
I had to rely on a custom patch of actix-web-static-files, to support actix-web 4 beta6. there is currently a pr on the official repo to support actix-web 4, but it most likely won't be merged until actix is stabilized.