Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Add stop words #135

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Add stop words #135

merged 3 commits into from
Apr 8, 2021

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Apr 6, 2021

closes #21

Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test where stop-words are set?

meilisearch-http/src/index/mod.rs Outdated Show resolved Hide resolved
meilisearch-http/src/index/updates.rs Outdated Show resolved Hide resolved
meilisearch-http/src/index/mod.rs Outdated Show resolved Hide resolved
meilisearch-http/src/index/mod.rs Outdated Show resolved Hide resolved
@irevoire irevoire requested a review from MarinPostma April 6, 2021 16:30
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an issue when using stop-words:

  • add documents with title: "the hobbit"
  • add the as stop-words
  • search for "the hobbit" -> I don't get any result, I should get my document with "the hobbit" if I'm not wrong.

Might be an issue in Milli, @Kerollmops?

@curquiza curquiza changed the title Stop words Add stop words Apr 7, 2021
@curquiza
Copy link
Member

curquiza commented Apr 7, 2021

Plus, it seems like this PR also fixes #85. Is it possible to do it in a separate PR, please?

My bad, checked with Marin, the bump of milli made the settings change!

Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

bors merge

bors bot added a commit that referenced this pull request Apr 8, 2021
135: Add stop words r=MarinPostma a=irevoire

closes #21 

Co-authored-by: tamo <tamo@meilisearch.com>
@MarinPostma
Copy link
Contributor

Merging since the issue mentionned by @curquiza are not relevant to transplant

@curquiza
Copy link
Member

curquiza commented Apr 8, 2021

> Plus, it seems like this PR also fixes #85. Is it possible to do it in a separate PR, please?

For the future, I would rather the jobs being in separate PR, if possible, maybe it's not the case here.

See comment above

@curquiza curquiza linked an issue Apr 8, 2021 that may be closed by this pull request
@curquiza
Copy link
Member

curquiza commented Apr 8, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 8, 2021

Build succeeded:

@bors bors bot merged commit f881e86 into main Apr 8, 2021
@bors bors bot deleted the stop-words branch April 8, 2021 11:37
bors bot added a commit that referenced this pull request Apr 15, 2021
146: Remove another unused legacy file r=MarinPostma a=irevoire

When doing #135 I missed an old useless file in the scr/routes directory

Co-authored-by: tamo <tamo@meilisearch.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate the new rankingRules implement stop words
3 participants