Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Enable distinct attribute #124

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Enable distinct attribute #124

merged 5 commits into from
Apr 20, 2021

Conversation

MarinPostma
Copy link
Contributor

No description provided.

@curquiza curquiza linked an issue Mar 29, 2021 that may be closed by this pull request
@MarinPostma MarinPostma force-pushed the distinct branch 2 times, most recently from e914eb7 to 0a86bd7 Compare April 19, 2021 17:41
@MarinPostma MarinPostma marked this pull request as ready for review April 19, 2021 17:41
@MarinPostma
Copy link
Contributor Author

the rebase broke the Cargo.lock, and I had to bump actix to make it compile again.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinct works 😁
However I can add my settings with /indexes/:uid/settings only and not with /indexes/:uid/settings/distinct-attribute

@MarinPostma
Copy link
Contributor Author

@curquiza good catch forgot to reenable this route 🤦

curquiza
curquiza previously approved these changes Apr 20, 2021
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magnifico!

irevoire
irevoire previously approved these changes Apr 20, 2021
meilisearch-http/tests/settings/get_settings.rs Outdated Show resolved Hide resolved
@MarinPostma MarinPostma dismissed stale reviews from irevoire and curquiza via f8c338e April 20, 2021 13:49
@irevoire irevoire self-requested a review April 20, 2021 13:50
@MarinPostma
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 20, 2021

Build succeeded:

@bors bors bot merged commit 63d443d into main Apr 20, 2021
@bors bors bot deleted the distinct branch April 20, 2021 14:00
@curquiza curquiza changed the title enable distinct Enable distinct attribute Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement distinctAttribute
3 participants