Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

return 202 on settings update / reset #106

Merged
merged 2 commits into from
Mar 18, 2021
Merged

return 202 on settings update / reset #106

merged 2 commits into from
Mar 18, 2021

Conversation

irevoire
Copy link
Member

closes #105

curquiza
curquiza suggested changes Mar 17, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also checked the reset_settings return a 202 in tests?

@irevoire
Copy link
Member Author

let me know if this is enough

@curquiza curquiza requested a review from MarinPostma March 17, 2021 14:10
curquiza
curquiza approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐰
but again let's wait for Marin's review 😇

MarinPostma
MarinPostma approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 18, 2021

Build succeeded:

@bors bors bot merged commit 1640d9e into meilisearch:main Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarinPostma MarinPostma MarinPostma approved these changes

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings update/reset should return a 202
3 participants
@irevoire @curquiza @MarinPostma