This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
API Keys - Introduce * wildcard char at the last position to express access to multiple indexes starting with the same string
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmourier
added
Ready For Review
gmourier
changed the title
* wildcard char at the last position to express multiple indexes starting with the same string* wildcard char at the last position to express access to multiple indexes starting with the same string
gmourier
force-pushed
the
release-v0.30.0
branch
from
2a87aa4 to
10a0d34
Compare
gmourier
force-pushed
the
allow-wildcard-char-at-last-pos-for-api-key-indexes-value
branch
from
0783a33 to
e898ab9
Compare
curquiza
previously approved these changes
Oct 19, 2022
Closed
2 tasks
Closed
2 tasks
|
@gmourier will probably not be ready for v0.30.0 |
|
@gmourier: confirmation, will not be in v0.30.0 but in v1! Sorry for the confusion! 🙇 |
gmourier
added
Ready To Be Implemented
…match multiple indexes starting with the same string
gmourier
force-pushed
the
allow-wildcard-char-at-last-pos-for-api-key-indexes-value
branch
from
e898ab9 to
48ed447
Compare
2 tasks
1 task
gmourier
added
Unplanified
gmourier
added
Q1:2023
v1.1.0
and removed
Unplanified
|
@Kerollmops, I think it misses the error case regarding the invalid index uid format in the |
…r-api-key-indexes-value
curquiza
approved these changes
Feb 16, 2023
gmourier
added
Implemented
This was referenced Mar 8, 2023
gmourier
deleted the
allow-wildcard-char-at-last-pos-for-api-key-indexes-value
branch
gmourier
added a commit
that referenced
this pull request
Apr 3, 2023
* Bump API version * Metrics API — Introduce a `/metrics` route for observability / monitoring purposes (#174) * init spec for /metrics * Rename spec filename and add description for metrics * update metrics name and type col in the metrics table; add auth errors * Add --enable-metrics-route to instance-options.md specification * Precise metrics * update open-api.yml * Add telemetry instance property * Mention metrics route on stats.get action * Add action * Precise action description * Rephrase future possibility * Add MEILI_ENABLE_METRICS_ROUTE * rename all the cli parameter to the experimental variant * Update text/0174-metrics-api.md Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Update open-api.yaml Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Update text/0085-api-keys.md Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Apply suggestions from code review Co-authored-by: Tamo <tamo@meilisearch.com> --------- Co-authored-by: Tamo <tamo@meilisearch.com> * API Keys - Introduce `*` wildcard char at the last position to express access to multiple indexes starting with the same string (#189) * Bump open-api spec * Precise that the * wildcard char can be used at the last position to match multiple indexes starting with the same string * Update future possibilities * Update the index wildcard pattern error message --------- Co-authored-by: Clément Renault <clement@meilisearch.com> * Documents API — Support a csv delimiter customization (#221) * specify the support of the csv-delimiter * Apply suggestions from code review * get rid of the last 'future possibility' that is being described in this PR * Update openAPI specification --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Update the geo-search spec to mention the fact that null is a valid geo field (#222) * GeoSearch — Add the `_geoBoundingBox` built-in filter (#223) * Add geoBoundingBox built-in filter description * Add missing parts * Update text/0059-geo-search.md Co-authored-by: Tamo <tamo@meilisearch.com> * Replace the top left / bottom right signature to a top right / bottom left signature --------- Co-authored-by: Tamo <tamo@meilisearch.com> * Search API — Add `facetStats` description (#224) * update search-api.md * rephrase * update open-api.yml * rephrase, add example on open-api.yml * Add examples * fix * Update text/0118-search-api.md Co-authored-by: Louis Dureuil <louis.dureuil@gmail.com> * rephrase * Clarify that facet stats are for all search results --------- Co-authored-by: Louis Dureuil <louis.dureuil@gmail.com> * Multi Search API (#225) * Add multi-search spec * Change possible HTTP return codes for index_not_found * Add multi-search to openAPI * Update telemetry * openAPI: shorter summary for multi-search * openAPI: attempt to remove superfluous "values" field in multisearch request/response * Apply review suggestions for openAPI Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Apply review suggestions for multi search API Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Add queries/results keys to openAPI examples Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * fix indent * Apply review suggestions for multi search API Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> * OpenAPI: Change summary to `Multi Search` * use backticks instead of ticks in multi search API example * Apply review suggestions for multi search API Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com> * remove superfluous newline from telemetry file Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> --------- Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com> * Add small blurb on index count / max size (#226) --------- Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: Louis Dureuil <louis.dureuil@gmail.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com> Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 API Diff
Summary
It's now possible to express access to multiple indexes starting by the same pattern in an API Key's
indexesfield by using the*char as a wildcard. The pattern is only considered when the*character is at the last position.e.g
products_*match all indexes starting byproducts_Related to meilisearch/meilisearch#2788
Changes
N/A
Out Of Scope
N/A
Attention To Reviewers
N/A
Misc