This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix finite pagination with placeholder search #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
added
the
no breaking
Kerollmops
approved these changes
Dec 15, 2022
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 4, 2023
3251: Add a specific test on finite pagination placeolder search with disti… r=curquiza a=ManyTheFish Add a specific test on finite pagination placeholder search with distinct attributes related to meilisearch/milli#743 related to #3200 poke `@curquiza` > note that the destination branch should be changed Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 5, 2023
3251: Add a specific test on finite pagination placeolder search with disti… r=curquiza a=ManyTheFish Add a specific test on finite pagination placeholder search with distinct attributes related to meilisearch/milli#743 related to #3200 poke `@curquiza` > note that the destination branch should be changed Co-authored-by: ManyTheFish <many@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this bug is reproducible on real datasets and is hard to isolate in a simple test.
related to: meilisearch/meilisearch#3200
poke @curquiza