This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix(smart-crop): Ensure that matches are all highlighted #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of only 1 query word was matching in an attribute, and this same word was matching several times in the crop window of same attribute, then only the first match was highlighted. Now we ensure that the computed "best matches interval" contains all the words that match in the same crop window. related to meilisearch/meilisearch#2627
curquiza
suggested changes
Jul 20, 2022
ManyTheFish
added
the
no breaking
curquiza
approved these changes
Jul 21, 2022
|
bors merge |
|
Build succeeded: |
ManyTheFish
added a commit
that referenced
this pull request
Aug 3, 2022
bors bot
added a commit
that referenced
this pull request
Aug 3, 2022
599: fix: Remove whitespace trimming during document id validation r=ManyTheFish a=ManyTheFish fix #592 related to meilisearch/meilisearch#2640 Co-authored-by: ManyTheFish <many@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of only 1 query word was matching in an attribute,
and this same word was matching several times in the crop window of the same attribute,
then only the first match was highlighted.
Now we ensure that the computed "best matches interval" contains all the words that match in the same crop window.
related to meilisearch/meilisearch#2627