Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Handle escaped characters in filters #427

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Handle escaped characters in filters #427

merged 4 commits into from
Jan 10, 2022

Conversation

irevoire
Copy link
Member

No description provided.

@irevoire irevoire marked this pull request as ready for review January 4, 2022 03:05
@irevoire irevoire added bug Something isn't working querying Related to the searching/fetch data algorithms. labels Jan 6, 2022
@irevoire irevoire requested a review from Kerollmops January 6, 2022 12:38
Kerollmops
Kerollmops suggested changes Jan 10, 2022
View reviewed changes
filter-parser/src/value.rs Outdated Show resolved Hide resolved
filter-parser/src/value.rs Outdated Show resolved Hide resolved
filter-parser/src/value.rs Outdated Show resolved Hide resolved
filter-parser/src/value.rs Show resolved Hide resolved
@irevoire @Kerollmops
Apply code suggestions
3c7ea1d 
Co-authored-by: Clément Renault <clement@meilisearch.com>
@irevoire irevoire requested a review from Kerollmops January 10, 2022 14:20
Kerollmops
Kerollmops suggested changes Jan 10, 2022
View reviewed changes
filter-parser/src/value.rs Outdated Show resolved Hide resolved
irevoire and others added 2 commits January 10, 2022 15:53
@irevoire @Kerollmops
Update filter-parser/src/value.rs
0fcde35 
Co-authored-by: Clément Renault <clement@meilisearch.com>
@irevoire
apply clippy suggestions
92804f6
@irevoire irevoire requested a review from Kerollmops January 10, 2022 14:59
Kerollmops
Kerollmops approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!
bors merge

@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

@bors bors bot merged commit 660eac5 into main Jan 10, 2022
@bors bors bot deleted the escaped_filter branch January 10, 2022 15:23
@curquiza curquiza mentioned this pull request Jan 17, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
bug Something isn't working querying Related to the searching/fetch data algorithms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irevoire @Kerollmops