This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Enable the grenad tempfile feature back #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the grenad
tempfilefeature back, when this is feature is disabled the sorter writes the entries in memory instead of on disk and therefore, consumes more memory. By enabling this feature grenad merges on disk by using thetempfiledependency.This PR also bumps milli to v0.3.1 where @ManyTheFish added an assert for when the allocator can't allocate and disable the default snappy compression in the
http-uicrate.