Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Better dependencies cache for CI #345

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Better dependencies cache for CI #345

merged 1 commit into from
Sep 8, 2021

Conversation

shekhirin
Copy link
Contributor

No description provided.

curquiza
curquiza reviewed Sep 7, 2021
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@curquiza
Copy link
Member

curquiza commented Sep 7, 2021

Hello @shekhirin! Thanks for your PR 🙂

What is the difference with the previous cache system we used in our CIs?

@shekhirin shekhirin force-pushed the chore/ci-deps-cache branch 2 times, most recently from 73ca699 to 20ebb69 Compare September 7, 2021 14:58
@shekhirin
Copy link
Contributor Author

Hey @curquiza,

It caches almost the same directories (https://github.com/Swatinem/rust-cache/blob/c5ed9ba6b7e1bb8aff90d43acd2f0af4990fa57c/src/common.ts#L76-L88), main difference is the clean up in target directory and some of ~/.cargo subdirectories before caching (https://github.com/Swatinem/rust-cache/blob/v1/src/save.ts#L35-L49).

@shekhirin shekhirin requested a review from curquiza September 7, 2021 15:28
@curquiza
Copy link
Member

curquiza commented Sep 8, 2021

Thanks for your explanation @shekhirin! :)

I put @irevoire as a final reviewer, as he was the first one integrating the cache to the CI :)

@curquiza curquiza requested review from irevoire and removed request for curquiza September 8, 2021 08:13
irevoire
irevoire approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!
It's faster and way more concise, once again thanks @shekhirin 🎉

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 8, 2021

Build succeeded:

@bors bors bot merged commit f5e418a into meilisearch:main Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@curquiza curquiza curquiza left review comments

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @curquiza @irevoire