Let the caller decide what kind of error they want to returns when parsing AscDesc

[irevoire]

This is one possible fix for #339
We would then need to patch these lines https://github.com/meilisearch/MeiliSearch/blob/main/meilisearch-http/src/index/search.rs#L110-L114 to return the error we want.

Another solution would be to add a parameter to the from_str to specify which context we are in.

[Kerollmops]

I am not sure it is the best solution, couldn't we introduce a new struct unit error instead, just for the AscDesc syntax? i.e. struct InvalidAscDescSyntax. We can then just do a text.to_string() on the caller side?

[irevoire]

How is a to_string going to solve our issue?
Do you mean something like a to_criterion_error and to_sort_error?

[Kerollmops]

No, What I want is to create a custom error specific to this error instead of returning a String in the Err variant. Then when an error is found i.e. Err(InvalidAscDescSyntax) we can simply create the error message like before i.e UserError::InvalidCriterionName or any other error. I don't like the fact that we return a text.to_string() in the error variant, it doesn't mean anything and is useless as we already have the text on the caller side.

[irevoire]

Ah ok I get the idea thanks!
I'll do it tomorrow morning

[Kerollmops]

Thank you very much, merging! 🧛
bors merge

[bors]

Build succeeded:

• Run Rustfmt
• Tests on macos-latest with stable
• Tests on ubuntu-18.04 with stable
• Tests on windows-latest with stable