This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Get sortable_fields from index only if criteria present in query #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
lazy-sortable-fields
branch
2 times, most recently
from
e818342 to
4f7e357
Compare
shekhirin
force-pushed
the
lazy-sortable-fields
branch
from
4f7e357 to
0e37955
Compare
shekhirin
changed the title
Kerollmops
approved these changes
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we don't need to retrieve
sortable_fieldsfrom the index if there's no anysort_criteriain the query.Small 🤏 optimization opportunity out there.