Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Sortable attributes in http-ui #332

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Sortable attributes in http-ui #332

merged 1 commit into from
Aug 30, 2021

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Aug 30, 2021 •
edited by Kerollmops
Loading

  • Add a reset_sortable_attribute method
  • Add the sortable_attributes to http-ui
  • Fix some broken test in http-ui

@irevoire irevoire requested a review from Kerollmops August 30, 2021 14:14
@irevoire
Copy link
Member Author

The tests I fixed were broken since multiple PRs.
I think we should either add them to the CI or delete them entirely (to me, they seem useless?)

Kerollmops
Kerollmops suggested changes Aug 30, 2021
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, could you remove your first commit as it is already implemented in #330.

@irevoire
Copy link
Member Author

Ah yes, sorry I totally forgot about this PR (even though I reviewed it 🙈 )
And what do you thinks of the tests?

@Kerollmops
Copy link
Member

Those tests are good, thank you for fixing them! :)

@irevoire irevoire force-pushed the http-ui/sortable-attributes branch from 21844be to d106eb5 Compare August 30, 2021 14:25
@irevoire irevoire changed the base branch from main to reset-sortable-attributes August 30, 2021 14:59
irevoire added a commit that referenced this pull request Aug 30, 2021
@irevoire
WIP: waiting for #332 to be merged
7e624b2
Kerollmops
Kerollmops approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
bors merge

@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

Build succeeded:

@bors bors bot merged commit 6cdb672 into reset-sortable-attributes Aug 30, 2021
@bors bors bot deleted the http-ui/sortable-attributes branch August 30, 2021 15:54
irevoire added a commit that referenced this pull request Aug 31, 2021
@irevoire
WIP: waiting for #332 to be merged
7cbf69f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irevoire @Kerollmops