Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Run all benchmarks once every friday #329

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Run all benchmarks once every friday #329

merged 2 commits into from
Sep 1, 2021

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Aug 25, 2021

All the benchmarks run every Friday on the main branch.
To avoid having pending benchmarks everywhere, we execute one benchmark every 8 hours.
Then the results are uploaded as if it was a normal user-run benchmark.

This PR closes #314 and #321

Comment on lines +23 to +26
- name: Set current branch name
shell: bash
run: echo "##[set-output name=name;]$(echo ${GITHUB_REF#refs/heads/})"
id: current_branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to get the current branch, this will be always main right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true but now I think about it I would like to keep the code as similar as possible to the original so we can just copy / paste everything below the env part when we have to update something to any of these files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

.github/workflows/cron_benchmarks_indexing.yml Outdated Show resolved Hide resolved
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thanks tamo!

@@ -9,7 +9,7 @@ on:
default: 'search_songs'

env:
HOME: "/home/runner" # The actions-rs/toolchain@v1 can fail we have no $HOME defined
BENCH_NAME: ${{ github.event.inputs.dataset_name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way better! 🚀

Comment on lines +23 to +26
- name: Set current branch name
shell: bash
run: echo "##[set-output name=name;]$(echo ${GITHUB_REF#refs/heads/})"
id: current_branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@irevoire
Copy link
Member Author

irevoire commented Sep 1, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 1, 2021

@bors bors bot merged commit 3e0a78a into main Sep 1, 2021
@bors bors bot deleted the ci/bench branch September 1, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark CI in a cron
2 participants