-
Notifications
You must be signed in to change notification settings - Fork 81
Run all benchmarks once every friday #329
Conversation
- name: Set current branch name | ||
shell: bash | ||
run: echo "##[set-output name=name;]$(echo ${GITHUB_REF#refs/heads/})" | ||
id: current_branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to get the current branch, this will be always main
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true but now I think about it I would like to keep the code as similar as possible to the original so we can just copy / paste everything below the env
part when we have to update something to any of these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 thanks tamo!
@@ -9,7 +9,7 @@ on: | |||
default: 'search_songs' | |||
|
|||
env: | |||
HOME: "/home/runner" # The actions-rs/toolchain@v1 can fail we have no $HOME defined | |||
BENCH_NAME: ${{ github.event.inputs.dataset_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
way better! 🚀
- name: Set current branch name | ||
shell: bash | ||
run: echo "##[set-output name=name;]$(echo ${GITHUB_REF#refs/heads/})" | ||
id: current_branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
bors merge |
All the benchmarks run every Friday on the
main
branch.To avoid having pending benchmarks everywhere, we execute one benchmark every 8 hours.
Then the results are uploaded as if it was a normal user-run benchmark.
This PR closes #314 and #321