Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Revert "Sort at query time" #318

Merged
merged 1 commit into from
Aug 21, 2021
Merged

Revert "Sort at query time" #318

merged 1 commit into from
Aug 21, 2021

Conversation

curquiza
Copy link
Member

Reverts #309

We revert this from main not because this leads to a bug, but because we don't want to release it now and we have to merge and release an hotfix on main.
Cf:

Once the v0.21.0 is released, we should merge again this awesome addition 👌

@curquiza curquiza requested a review from Kerollmops August 20, 2021 16:15
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM curqui!
bors merge

bors bot added a commit that referenced this pull request Aug 20, 2021
318: Revert "Sort at query time" r=Kerollmops a=curquiza

Reverts #309

We revert this from `main` not because this leads to a bug, but because we don't want to release it now and we have to merge and release an hotfix on `main`.
Cf:
- #316
- #317

Once the v0.21.0 is released, we should merge again this awesome addition 👌 

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@Kerollmops
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 21, 2021

@bors bors bot merged commit 0d1f83b into main Aug 21, 2021
@bors bors bot deleted the revert-309-sort-at-query-time branch August 21, 2021 08:34
@Kerollmops Kerollmops mentioned this pull request Aug 23, 2021
@curquiza curquiza added the DB breaking The related changes break the DB label Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DB breaking The related changes break the DB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants