Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Remove max values by facet limit for facet distribution #303

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

ManyTheFish
Copy link
Member

No description provided.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!
bors merge

@Kerollmops Kerollmops added the DB breaking The related changes break the DB label Aug 16, 2021
@bors
Copy link
Contributor

bors bot commented Aug 16, 2021

@bors bors bot merged commit 1541bce into main Aug 16, 2021
@bors bors bot deleted the remove-facet-distribution-limit branch August 16, 2021 10:33
@bb
Copy link

bb commented Aug 16, 2021

Regarding the breaking-change label: I think this is breaking compared to earlier 0.21.x versions but it's in line with <=0.20.x, isn't it?

@curquiza
Copy link
Member

This is breaking for the users of the library Milli, so for the MeiliSearch repository. But a breaking on Milli's side does not involve this is breaking for MeiliSearch.
Here, in this PR, a public function changed, so the milli's library is breaking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DB breaking The related changes break the DB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants