Change settings behavior #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
change-settings-behavior
branch
2 times, most recently
from
660e1c2 to
5bb80e1
Compare
MarinPostma
force-pushed
the
change-settings-behavior
branch
from
5bb80e1 to
de4caef
Compare
|
bors try |
tryBuild succeeded: |
MarinPostma
force-pushed
the
change-settings-behavior
branch
from
4526cbc to
d114250
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially implements #824.
Returning the field distribution for all know fields is more complicated that anticipated, see #824 (comment)
If we decide to to it anyway, and find a reasonable solution, I will make another PR.
fix #853 by resetting displayed and searchable attributes to wildcard when attributes are set to
[]in the all settings route. @curquiza @bidoubiwa can you confirm me that this is the expected behavior?