Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default embedder #4938

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Remove default embedder #4938

merged 7 commits into from
Sep 19, 2024

Conversation

dureuill
Copy link
Contributor

Pull Request

Related issue

Fixes #4738

What does this PR do?

See public usage

  • Remove hybrid.embedder boolean from analytics because embedder is now mandatory and so the boolean would always be true
  • Rework search kind so that a search without query but with vector is a vector search regardless of (non-zero) semantic ratio

@dureuill dureuill added the breaking change The related changes are breaking for the users label Sep 17, 2024
@dureuill dureuill added this to the v1.11.0 milestone Sep 17, 2024
@ManyTheFish
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Sep 19, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 5f474a6 into main Sep 19, 2024
10 checks passed
@meili-bors meili-bors bot deleted the remove-default-embedder branch September 19, 2024 09:51
@irevoire irevoire added the experimental feature Related to an experimental feature label Oct 28, 2024
@meili-bot meili-bot added the v1.11.0 PRs/issues solved in v1.11.0 released on 2024-10-28 label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The related changes are breaking for the users experimental feature Related to an experimental feature v1.11.0 PRs/issues solved in v1.11.0 released on 2024-10-28
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always require embedder in semantic search and similar search
4 participants