Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add facets support to federated #4929

Merged
merged 26 commits into from
Sep 18, 2024
Merged

Add facets support to federated #4929

merged 26 commits into from
Sep 18, 2024

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Sep 12, 2024 •
edited
Loading

Pull Request

Related issue

What does this PR do?

See public usage

Caution

This PR introduces a 🚨breaking change🚨: queries.facets when federation is present and non-null is now an error

Implementation standpoint:

  • Facet distribution: fix issue where truncated facet distribution would have a wrong order
  • facet distribution: implement Display for OrderBy

@dureuill dureuill added this to the v1.11.0 milestone Sep 12, 2024
@dureuill dureuill added breaking change The related changes are breaking for the users missing usage Description of the feature usage is missing in the appropriate place and removed missing usage Description of the feature usage is missing in the appropriate place labels Sep 12, 2024
@dureuill dureuill mentioned this pull request Sep 16, 2024
Closed
@dureuill dureuill marked this pull request as draft September 16, 2024 09:42
@dureuill dureuill force-pushed the add-facets-to-federated branch from aadc787 to d9e0df7 Compare September 17, 2024 08:43
@dureuill dureuill marked this pull request as ready for review September 17, 2024 15:23
Kerollmops
Kerollmops requested changes Sep 18, 2024
View reviewed changes
meilisearch/src/search/federated.rs Outdated Show resolved Hide resolved
@dureuill dureuill force-pushed the add-facets-to-federated branch from 5e7604d to 00f8d03 Compare September 18, 2024 09:46
Kerollmops
Kerollmops approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful 😻
bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Sep 18, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 29c3aca into main Sep 18, 2024
10 checks passed
@meili-bors meili-bors bot deleted the add-facets-to-federated branch September 18, 2024 10:19
@meili-bot meili-bot added the v1.11.0 PRs/issues solved in v1.11.0 released on 2024-10-28 label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
breaking change The related changes are breaking for the users v1.11.0 PRs/issues solved in v1.11.0 released on 2024-10-28
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Support facet distribution for federated search multi-search with federation not returning facets
3 participants
@dureuill @Kerollmops @meili-bot