Cap the maximum memory of the grenad sorters #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
added
the
performance
|
/benchmark indexing |
|
@Kerollmops does this PR fix #4152? |
|
Here are your indexing benchmarks diff 👊 |
irevoire
previously approved these changes
Feb 7, 2024
|
/benchmark indexing |
|
IMO, considering the RAM we give to our big client, I would not be shocked if we went as up as 1GiB 👀 |
Kerollmops
changed the title
|
Here are your indexing benchmarks diff 👊 |
|
Seems ok to me, as #4350 will probably change many things. This PR is here to reduce the memory crashes not to speed up the engine. We can work on improving the performances in a lot of other domains. bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Feb 8, 2024
4388: Cap the maximum memory of the grenad sorters r=Kerollmops a=Kerollmops This PR clamps the memory usage of the grenad sorters to a reasonable maximum. Grenad sorters are opened on multiple threads at a time. This can result in higher memory usage than expected, even though it shouldn't consume more than the memory available. Fixes #4152. Co-authored-by: Clément Renault <clement@meilisearch.com>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
meili-bors bot
added a commit
that referenced
this pull request
Feb 8, 2024
4388: Cap the maximum memory of the grenad sorters r=irevoire a=Kerollmops This PR clamps the memory usage of the grenad sorters to a reasonable maximum. Grenad sorters are opened on multiple threads at a time. This can result in higher memory usage than expected, even though it shouldn't consume more than the memory available. Fixes #4152. Co-authored-by: Clément Renault <clement@meilisearch.com>
|
Build failed: |
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clamps the memory usage of the grenad sorters to a reasonable maximum. Grenad sorters are opened on multiple threads at a time. This can result in higher memory usage than expected, even though it shouldn't consume more than the memory available.
Fixes #4152.