Enable the client to specify a custom csv delimiter for parsing documents #2803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #2806
This PR adds the ability to specify custom csv delimiters, which I think is a very common use case, especially with large amounts of pre-existing data.
Description
In
meilisearch-lib
, I added au8
parameter to theDocumentAdditionFormat::Csv
document type.In
meilisearch-http
, I added the fieldpub csv_delimiter: Option<char>,
toUpdateDocumentsQuery
(the actual query parameter is in camelCase thanks to serde:csvDelimiter
)The default delimiter is the comma (44), just like before. For example, the query for data delimited with semicolons:
cargo test
succeeded on my system, and I was able to add documents using different delimiters using postman.PR checklist
Please check if your PR fulfills the following requirements: