Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports text separation #595

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Supports text separation #595

merged 5 commits into from
Jul 2, 2024

Conversation

NoodleSamaChan
Copy link
Contributor

Pull Request

Related issue

#526

What does this PR do?

Added two new settings: separatorTokens and nonSeparatorTokens with get, update, and reset methods associated.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

irevoire
irevoire requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, codewise it’s perfect, but there is a few comments missing here and there.

Also it looks like you have a conflict with main

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
@NoodleSamaChan NoodleSamaChan force-pushed the supports_text_separation branch from 1f6faac to f4361c4 Compare July 2, 2024 09:25
irevoire
irevoire requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we're almost there, just a few comments remaining

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
src/settings.rs Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
NoodleSamaChan and others added 3 commits July 2, 2024 11:29
@NoodleSamaChan @irevoire
Update src/settings.rs
c57d0b2 
Co-authored-by: Tamo <irevoire@protonmail.ch>
@NoodleSamaChan @irevoire
Update src/settings.rs
979d460 
Co-authored-by: Tamo <irevoire@protonmail.ch>
@NoodleSamaChan
changed some rebase issues
968dfab
irevoire
irevoire approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jul 2, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit fafebbf into meilisearch:main Jul 2, 2024
7 checks passed
@curquiza curquiza added the enhancement New feature or request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoodleSamaChan @irevoire @curquiza