Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination feature for v0.30.0 #595

Merged

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Nov 16, 2022

Adds the new page selection component

TODO:

  • Add tests

Response:

  • limit is now optional
  • offset is now optional
  • estimatedTotalHits is now optional
  • new page is optional
  • new hitsPerPage is optional
  • new totalPages is optional
  • new totalHits is optional

Tests

  • add tests for new search parameters: page and hitsPerPage check totalHits, totalPages in the response.

@alallema alallema force-pushed the bump-meilisearch-v0.30.0 branch from e5fd493 to 6dd53c9 Compare November 16, 2022 10:00
@alallema alallema added the enhancement New feature or request label Nov 16, 2022
@alallema alallema force-pushed the bump-meilisearch-v0.30.0 branch from dee4333 to c54dbf0 Compare November 17, 2022 11:54
@alallema alallema force-pushed the add_pagination_feature_for_v0.30.0 branch 2 times, most recently from 32a9f09 to 09e80c6 Compare November 17, 2022 15:17
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@alallema alallema merged commit 441b507 into bump-meilisearch-v0.30.0 Nov 28, 2022
@alallema alallema deleted the add_pagination_feature_for_v0.30.0 branch November 28, 2022 14:03
bors bot added a commit that referenced this pull request Nov 28, 2022
588: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#221

This PR:
- gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.30.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._

- #597 
- #595 
- #596 
- #598
- #603

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
bors bot added a commit that referenced this pull request Nov 28, 2022
588: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#221

This PR:
- gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.30.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._

- #597 
- #595 
- #596 
- #598
- #603

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants