Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes related to the next MeiliSearch release (v0.22.0) #318

Merged
merged 9 commits into from
Sep 13, 2021
Merged

Changes related to the next MeiliSearch release (v0.22.0) #318

merged 9 commits into from
Sep 13, 2021

Conversation

meili-bot
Copy link
Contributor

Related to this issue: meilisearch/integration-guides#139

This PR:

  • gathers the changes related to the next MeiliSearch release (v0.22.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of MeiliSearch.
  • might eventually contain test failures until the MeiliSearch v0.22.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.22.0) is out.

This PR is auto-generated for the pre-release week purpose.

alallema and others added 2 commits September 9, 2021 17:45
@alallema @curquiza
Update .code-samples.meilisearch.yaml
85c0703 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@alallema
Fix test for more relevancy on sort
d0f4a5a
@alallema alallema force-pushed the bump-meilisearch-v0.22.0 branch from 3b98be1 to d0f4a5a Compare September 13, 2021 08:58
@alallema alallema marked this pull request as ready for review September 13, 2021 12:43
@alallema alallema requested a review from bidoubiwa September 13, 2021 12:43
bidoubiwa
bidoubiwa suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add sort line 263 in .code-samples.meilisearch.yaml

.code-samples.meilisearch.yaml Show resolved Hide resolved
meilisearch/tests/index/test_index_search_meilisearch.py Show resolved Hide resolved
meilisearch/tests/index/test_index_search_meilisearch.py Show resolved Hide resolved
meilisearch/tests/index/test_index_search_meilisearch.py Show resolved Hide resolved
bidoubiwa
bidoubiwa suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code sample should be updated:

settings_guide_ranking_rules_1: |-
  client.index('movies').update_settings({
    'rankingRules': [
        'words',
        'typo',
        'proximity',
        'attribute',
        'exactness',
        'asc(release_date)',
        'desc(rank)'
    ]
  })

@alallema alallema requested a review from bidoubiwa September 13, 2021 14:50
bidoubiwa
bidoubiwa approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 13, 2021

Build succeeded:

@bors bors bot merged commit afa7bb3 into main Sep 13, 2021
@bors bors bot deleted the bump-meilisearch-v0.22.0 branch September 13, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza left review comments

@alallema alallema alallema left review comments

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meili-bot @alallema @curquiza @bidoubiwa