Support boolean parameters in Index.get_documents
#1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanders41
reviewed
Dec 3, 2024
martinnj
changed the title
GET logic in Index.get_documentsIndex.get_documents
martinnj
force-pushed
the
martin/issue-1044
branch
from
7bd9935 to
f6897e1
Compare
sanders41
added
breaking-change
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1044
What does this PR do?
GETinIndex.get_documents. This solves the urlparse encoding problem described in the issues.tests/index/test_index_document_meilisearch.pyRequest for comments
I introduced the
serialize_bodyvariable because it made my life easier when figuring things out. I'm very much open for suggestions on how to handle that case.