Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.11.0] Fix AI-powered search feature following breaking changes #1019

Closed
2 tasks
curquiza opened this issue Sep 23, 2024 · 1 comment · Fixed by #1020
Closed
2 tasks

[v1.11.0] Fix AI-powered search feature following breaking changes #1019

curquiza opened this issue Sep 23, 2024 · 1 comment · Fixed by #1020
Labels
good first issue Good for newcomers Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

Related to meilisearch/integration-guides#303

Explanation of the feature

Usage: https://meilisearch.notion.site/v1-11-AI-search-changes-0e37727193884a70999f254fa953ce6e?pvs=74

Breaking:

  • When using the semantic or the hybrid search, hybrid.embedder is now a mandatory parameter in GET and POST /indexes/{:indexUid}/search
  • As a consequence, it is now mandatory to pass hybrid even for full-vector search (with only vector and not q)
  • embedder is now a mandatory parameter in GET and POST /indexes/{:indexUid}/similar
  • Ignore non-zero semanticRatio when vector is passed but not q: a semantic search will be performed.
  • The default model for OpenAI is now text-embedding-3-small instead of text-embedding-ada-002.

TODO

  • Ensure the breaking changes are applied in the code base
  • Fix tests failing due to the of breaking changes

⚠️ Make PRs pointing to bump-meilisearch-v1.11.0 and NOT main. Please do 1 PR for all of these changes, and not several.
@curquiza curquiza added good first issue Good for newcomers Meilisearch bump Changes related to the Meilisearch bump version labels Sep 23, 2024
@curquiza curquiza mentioned this issue Sep 23, 2024
Closed
39 tasks
@dureuill dureuill mentioned this issue Sep 30, 2024
Merged
meili-bors bot added a commit that referenced this issue Sep 30, 2024
@meili-bors @dureuill
Merge #1020
c264013 
1020: Fix tests by passing embedders r=sanders41 a=dureuill

# Pull Request

## Related issue
Fixes #1019 

## What does this PR do?
- Change comment stating the default model for OpenAI
- Add `document_template_max_bytes` to models
- Fix tests



Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@curquiza curquiza linked a pull request Sep 30, 2024 that will close this issue
Fix tests by passing embedder #1020
Merged
@curquiza
Copy link
Member Author

Closed by #1020

Will be released once #1018 is merged

@curquiza curquiza closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests by passing embedder meilisearch/meilisearch-python
1 participant
@curquiza