Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tasks reverse test #710

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Fix flaky tasks reverse test #710

merged 4 commits into from
Dec 30, 2024

Conversation

Strift
Copy link
Collaborator

@Strift Strift commented Dec 19, 2024

Pull Request

Fixes a flaky tests about getting tasks in reverse order

@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Dec 19, 2024
@Strift Strift marked this pull request as draft December 19, 2024 04:53
@curquiza
Copy link
Member

@Strift can you rebase the PR once bump-meilisearch-v1.12 is merged? 😊

Base automatically changed from bump-meilisearch-v0.12.0 to main December 23, 2024 11:48
@Strift Strift self-assigned this Dec 27, 2024
@Strift Strift force-pushed the fix/tasks-reverse-test branch from 6bf667b to 32483ae Compare December 27, 2024 09:33
@Strift Strift marked this pull request as ready for review December 27, 2024 09:58
@Strift
Copy link
Collaborator Author

Strift commented Dec 27, 2024

@curquiza managed to fix the flakiness of the test 🙌

@Strift Strift requested review from norkunas and curquiza December 27, 2024 09:59
curquiza
curquiza approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the best 🤘

bors merge

meili-bors bot added a commit that referenced this pull request Dec 30, 2024
@meili-bors @Strift
Merge #710
19ac7a0 
710: Fix flaky tasks reverse test r=curquiza a=Strift

# Pull Request

Fixes a flaky tests about getting tasks in reverse order


Co-authored-by: Strift <lau.cazanove@gmail.com>
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Dec 30, 2024

Build failed:

@curquiza
Copy link
Member

a timeout, not the same flaky, hope it's really punctual 🤞

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Dec 30, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit ec91f26 into main Dec 30, 2024
33 checks passed
@meili-bors meili-bors bot deleted the fix/tasks-reverse-test branch December 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@norkunas norkunas Awaiting requested review from norkunas

Assignees

@Strift Strift

Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strift @curquiza