Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rankingScoreThreshold to SimilarDocumentsQuery #675

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Add rankingScoreThreshold to SimilarDocumentsQuery #675

merged 1 commit into from
Sep 15, 2024

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Sep 2, 2024

Pull Request

Related issue

Fixes #671

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas mentioned this pull request Sep 2, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (ccd4cfd) to head (7dabe50).
Report is 37 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   83.91%   85.00%   +1.08%     
==========================================
  Files          49       51       +2     
  Lines        1262     1307      +45     
==========================================
+ Hits         1059     1111      +52     
+ Misses        203      196       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas norkunas force-pushed the ranking-score-threshold branch from 9aabb7d to 1ff11d1 Compare September 2, 2024 18:58
@norkunas norkunas force-pushed the ranking-score-threshold branch from 1ff11d1 to 7dabe50 Compare September 2, 2024 20:20
brunoocasali
brunoocasali approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Sep 15, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit ceacf5f into meilisearch:main Sep 15, 2024
29 of 30 checks passed
@brunoocasali brunoocasali added the enhancement New feature or request label Sep 15, 2024
@norkunas norkunas deleted the ranking-score-threshold branch September 16, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

@curquiza curquiza Awaiting requested review from curquiza

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for rankingScoreThreshold in SimilarDocumentsQuery
2 participants
@norkunas @brunoocasali