Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix similar docs code sample #673

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix similar docs code sample #673

merged 1 commit into from
Sep 15, 2024

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Sep 2, 2024

Pull Request

Related issue

Fixes #672

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors merge

meili-bors bot added a commit that referenced this pull request Sep 9, 2024
673: Fix similar docs code sample r=brunoocasali a=norkunas

# Pull Request

## Related issue
Fixes #672

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
Copy link
Contributor

meili-bors bot commented Sep 9, 2024

Build failed:

@norkunas
Copy link
Collaborator Author

norkunas commented Sep 9, 2024

@brunoocasali #674 should be merged first

@brunoocasali
Copy link
Member

bors merge

@brunoocasali brunoocasali added the documentation Improvements or additions to documentation label Sep 15, 2024
@meili-bors meili-bors bot merged commit 884789e into main Sep 15, 2024
27 of 28 checks passed
@meili-bors meili-bors bot deleted the fix-code-sample branch September 15, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Error: Incorrect Method Name getSimilar() Instead of searchSimilarDocuments()
2 participants