Handle unexpected but valid JSON content-types #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
bug/edge-content-type
branch
from
114addf to
9e766fd
Compare
norkunas
reviewed
Jul 23, 2024
norkunas
reviewed
Jul 25, 2024
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
When using Meilisearch analytics aka (meilisearch edge) users were facing weird decoding issues using this SDK.
I found the reason was some particular routes on the edge were responding a valid body but they contained a content-type that was not recognized as valid by this SDK
application/json; charset=utf-8.What does this PR do?