Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CodeCov coverage report support #616

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

connorhu
Copy link
Contributor

@connorhu connorhu commented Feb 14, 2024

Pull Request

Related issue

Fixes #567

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@connorhu connorhu marked this pull request as ready for review February 14, 2024 09:35
Copy link

codecov bot commented Feb 14, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@connorhu connorhu force-pushed the feature/codecov branch 3 times, most recently from 7868a8f to d0a029a Compare February 14, 2024 10:08
@curquiza curquiza self-requested a review February 14, 2024 11:00
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Feb 14, 2024
@connorhu connorhu force-pushed the feature/codecov branch 2 times, most recently from 8f4f6fa to 45fd08f Compare February 15, 2024 12:01
@curquiza curquiza requested a review from norkunas February 16, 2024 13:54
@curquiza
Copy link
Member

@norkunas if you have the time and you are around, feel free to review this one as well (same work than on the Symfony repo)

@connorhu
Copy link
Contributor Author

To be honest, I don't know why the test stopped.

@curquiza
Copy link
Member

@connorhu
re-running

@connorhu
Copy link
Contributor Author

Rebased the PR to keep the main behind it up-to-date.

@norkunas
Copy link
Collaborator

bors merge

@curquiza curquiza merged commit 70f5ec9 into meilisearch:main Feb 16, 2024
11 of 12 checks passed
@connorhu connorhu deleted the feature/codecov branch February 16, 2024 16:10
meili-bors bot added a commit that referenced this pull request Mar 11, 2024
617: Changes related to the next Meilisearch release (v1.7.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#296

This PR:
- gathers the changes related to the next Meilisearch release (v1.7.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.7.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.7.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


621: Update version for the next release (v1.7.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-php to a new version: "v1.7.0"

---

Part of this work
#617

---

This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. 

 ## ⚠️ Breaking changes

* `scoreDetails` feature is not experimental anymore. You can directly use `showRankingScoreDetails` during a search without activating the experimental feature 🎉

## 🚀 Enhancements

* Includes any changes related to Hybrid search introduced in Meilisearch v1.7.0 🎉

## ⚙️ Maintenance/misc

* Added CodeCov coverage report support (#616) connorhu

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
meili-bors bot added a commit that referenced this pull request Mar 11, 2024
621: Update version for the next release (v1.7.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-php to a new version: "v1.7.0"

---

Part of this work
#617

---

This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. 

 ## ⚠️ Breaking changes

* `scoreDetails` feature is not experimental anymore. You can directly use `showRankingScoreDetails` during a search without activating the experimental feature 🎉

## 🚀 Enhancements

* Includes any changes related to Hybrid search introduced in Meilisearch v1.7.0 🎉

## ⚙️ Maintenance/misc

* Added CodeCov coverage report support (#616) connorhu

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeCov
3 participants