Add multiSearch
#481
Merged
Add multiSearch
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Mar 22, 2023
| @@ -30,6 +31,7 @@ class Client | |||
| use HandlesTasks; | |||
| use HandlesKeys; | |||
| use HandlesSystem; | |||
| use HandlesMultiSearch; | |||
There was a problem hiding this comment.
Just interesting - what's the decision to use so many traits that are used only once here and that just hides the code?
There was a problem hiding this comment.
I'm following the adopted pattern, but in fact, I agree because the Client class would be humongous if all those methods were defined directly there.
There was a problem hiding this comment.
Hey @norkunas,
@brunoocasali left on holliday so I'll be releasing this PR. I agree with you as well, nonetheless I suggest we open an issue on this subject for a possible refacto of that section and merge this one as it is. What do you think?
There was a problem hiding this comment.
hi @bidoubiwa, i don't mind :)
norkunas
reviewed
Mar 22, 2023
norkunas
reviewed
Mar 22, 2023
brunoocasali
force-pushed
the
add-csv-delimiter
branch
3 times, most recently
from
649abf4 to
4956257
Compare
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
Updates the requirements on [phpstan/phpstan](https://github.com/phpstan/phpstan) to permit the latest version. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.10.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.3...1.10.6) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
brunoocasali
force-pushed
the
add-multi-search
branch
from
cef5d73 to
75d2564
Compare
brunoocasali
force-pushed
the
add-multi-search
branch
from
75d2564 to
7d363f3
Compare
bidoubiwa
approved these changes
Mar 28, 2023
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
489: Update version for the next release (v1.1.0) r=bidoubiwa a=meili-bot This version introduces features released on Meilisearch v1.1.0 🎉 Check out the changelog of [Meilisearch v1.1.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ### 🚀 Enhancements - Add a new optional argument to `addDocumentsCsv`, `addDocumentsCsvInBatches`, and `updateDocumentsCsvInBatches`. This argument allows you to customize the separator character in your `csv` file. (#480) `@brunoocasali` - Add a new getter, the `facetStats` on `SearchResult` (#487) `@brunoocasali.` - Add `$client->multiSearch()` method to execute multiple search requests simultaneously with different configurations. (#481) `@brunoocasali` - Introduce `SearchQuery` builder class to build the search requests used in the `multiSearch`. Usage example: ```php $this->client->multiSearch([ (new SearchQuery())->setIndexUid('books') ->setQuery('princ') ->setSort(['author:desc']), (new SearchQuery())->setIndexUid('movies') ->setQuery('be') ->setHitsPerPage(4) ->setFilter(['duration-float > 3']), ]); ```⚠️ The `SearchQuery` was not meant to be used if the regular `$index->search()` requests (yet). Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchQuerywhich will handle future search requests$clientcalledmultiSearch()which will take an array ofSearchQuery.