Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to the next MeiliSearch release (v0.21.0) #875

Merged
merged 29 commits into from
Aug 24, 2021

Conversation

meili-bot
Copy link
Contributor

Related to this issue: meilisearch/integration-guides#117

This PR:

  • gathers the changes related to the next MeiliSearch release (v0.21.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of MeiliSearch. Until there is an RC version, the tests should be valid against the alpha versions of transplant.
  • might eventually contain test failures until the MeiliSearch v0.21.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.21.0) is out.

This PR is auto-generated for the pre-release week purpose. Exceptionally for this release, the pre-release time will be more than just one week.

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Apr 27, 2021
@curquiza curquiza removed the skip-changelog The PR will not appear in the release changelogs label Apr 27, 2021
@bidoubiwa bidoubiwa force-pushed the bump-meilisearch-v0.21.0 branch from af00fec to 9b4d991 Compare July 5, 2021 16:00
bidoubiwa added 3 commits July 5, 2021 18:15
* Change builDate with commitDate

* Update tests
* Remove await from playground

* Upate waitforpendingupdate conditions
@bidoubiwa
Copy link
Contributor

bidoubiwa commented Jul 6, 2021

Tests have been set to skip until fixed by meilisearch engine.

@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Jul 7, 2021
bidoubiwa and others added 3 commits July 28, 2021 19:25
* Add searchGet method to handle search on GET

* Update readme and code samples

* Fix linting
@curquiza curquiza requested a review from alallema August 23, 2021 15:28
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some modifications missing in the .code_sample.meilisearch.yaml:
phrase_search_1 doesn't appear.
search_parameter_guide_highlight_1 and search_parameter_guide_matches_1 should have change request shifu for winter feast
Also in the README maybe we can add the new status update processing in the list line 169

With the `updateId`, you can check the status (`enqueued`, `processed` or `failed`)

@bidoubiwa bidoubiwa requested a review from alallema August 24, 2021 14:15
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🎉!

@bidoubiwa
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Aug 24, 2021
@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 24, 2021

@bors bors bot merged commit 355edeb into main Aug 24, 2021
@bors bors bot deleted the bump-meilisearch-v0.21.0 branch August 24, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants