Update CONTRIBUTING.md with minimal Node version #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with minimum version of node required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 17 17
Lines 1465 1465
Branches 307 307
=======================================
Hits 1433 1433
Misses 32 32 ☔ View full report in Codecov by Sentry. |
curquiza
approved these changes
Dec 2, 2024
curquiza
changed the title
flevi29
reviewed
Dec 3, 2024
Comment on lines
+37
to
+39
| - Node.js >= v16 and node <= 18 | ||
| - Yarn | ||
|
|
||
| - vitest |
There was a problem hiding this comment.
While it might run on Node.js 16, we're not testing it, we're testing 18 and 20. And we shouldn't as it's End Of Life.
vitest shouldn't be required, yarn installs it, it's part of the devDependencies.
I guess it's fine for now, I might tweak it in the future. Also Node.js 18 EOL is approaching, when it arrives, I'll change this.
meili-bors bot
added a commit
that referenced
this pull request
Dec 23, 2024
1797: Update version for the next release (v0.47.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-js to a new version: "v0.47.0" CHANGELOGS 👇 This version introduces features released on Meilisearch v1.12.0 🎉 Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information. ## 🚀 Enhancements - **Addition:** #1775 Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. ```ts // fetch one batch using batch UID const batch = await client.getBatch(123) // fetch all batches const batches = await client.getBatches() ``` - **Addition:** #1774 The `getTasks()` methods now accept a `reverse` parameter to retrieve tasks in reverse chronological order. ```ts const tasks = await client.getTasks({ reverse: true }); ``` - **Addition:** #1790 Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings. ```ts // disable prefix search await client.index('myIndex').updatePrefixSearch('disabled') // reset prefix search settings await client.index('myIndex').resetPrefixSearch() // disable facet search await client.index('myIndex').updateFacetSearch(false) // reset facet search settings await client.index('myIndex').resetFacetSearch() ``` - **Update:** #1773 The `_matchesPosition` array now contains an `indices` array the text was matched in an array. When searching for `fantasy` in a document that has a searchable `genre` field with the value `genre: ["fantasy", "adventure"]`, the matches position will be as follow: ```ts { genre: [{ start: 0, length: 7, indices: [0] }] } ``` Which means: - There was a single match in the `genre` array (array length == 1) - The match started as position `0` (the first character, "f") - The match has a length of `7` (the entire "fantasy" word) - The match was in the first item of the array (indices == [0]) ⚙️ Maintenance/misc - Update CONTRIBUTING.md with minimal Node version (#1788) Thanks again to `@/irevoire,` `@/Barabasbalazs,` `@/irevoire,` `@/curquiza,` and `@/Strift.` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the minimum version of node required
Hey, I tried to run the test and encountered multiple errors coming from our outdated
CONTRIBUTING.md.It says the minimum version of node supported is the v14, but when I tried it gave me this error:
Then I tried the v15 and it gave me this error:
Finally, the v16 worked, so the range of accepted version should be v16 to v18.
Then I tried to run the tests, which doesn't work anymore because apparently we now requires the installation of vitest