Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull the latest in the CI instead of forcing the v1.11 #1751

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Oct 30, 2024

Pull Request

Related issue

Fixes #1750

What does this PR do?

  • Use the latest in the CI for testing instead of forcing the usage of the v1.11

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added the bug Something isn't working label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (4fe62f3) to head (f18cf14).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          17       17           
  Lines        1465     1465           
  Branches      307      307           
=======================================
  Hits         1433     1433           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdubus mdubus marked this pull request as ready for review October 30, 2024 07:23
@mdubus mdubus requested a review from nicolasvienot October 30, 2024 08:54
@mdubus mdubus changed the title Revert forcing the CI using the v1.11 instead of the latest fix: pull the latest in the CI instead of forcing the v1.11 Oct 30, 2024
@flevi29
Copy link
Collaborator

flevi29 commented Oct 31, 2024

bors merge

Copy link
Contributor

meili-bors bot commented Oct 31, 2024

@meili-bors meili-bors bot merged commit 12b5877 into main Oct 31, 2024
7 checks passed
@meili-bors meili-bors bot deleted the update_ci_test_to_latest branch October 31, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert forcing the Meilisearch version to v1.11 instead of the latest
3 participants