Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat accept the frequency value for the matchingStrategy search #565

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Aug 21, 2024

Pull Request

Related issue

Fixes #540

What does this PR do?

  • This PR accept the frequency value for the matchingStrategy search

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (1dfc51b) to head (13d1554).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          11       11           
  Lines        2043     2043           
=======================================
  Hits         1772     1772           
  Misses        165      165           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Aug 21, 2024
@curquiza
Copy link
Member

@Ja7ad can you rebase to only include the changes of the PR please, and not the proximityPRecision changes?

@Ja7ad Ja7ad force-pushed the feat/matching-strategy branch from 62aabd7 to 13d1554 Compare August 21, 2024 14:57
@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Aug 21, 2024

@Ja7ad can you rebase to only include the changes of the PR please, and not the proximityPRecision changes?

Done

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Aug 21, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 7bd9c23 into meilisearch:main Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.9] Accept the frequency value for the matchingStrategy search parameter
2 participants