Make client List() parameters optional #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
previously approved these changes
Jun 30, 2020
eskombro
force-pushed
the
make_client_list_parameters_optional
branch
from
0c63781 to
f40d97d
Compare
curquiza
approved these changes
Jun 30, 2020
|
@alexisvisco I merged this PR as the tests where failing in master and this seemed a little urgent, but I requested your review to see if you agree with this! So feel free to comment, etc if you have a minute :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue detailed in #55
Listmethod parameters (limit,offsetandattributesToRetrieve) should be optional, and shouldn't be sent on the request unless the user has set them to a specific valueCloses #55