Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facet search method #543

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Conversation

migueltarga
Copy link
Contributor

@migueltarga migueltarga commented Jul 24, 2024

Pull Request

Related issue

Fixes #470

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@migueltarga migueltarga changed the title Add New Facet Search Method - https://www.meilisearch.com/docs/reference/api/facet_search Add New Facet Search Method Jul 24, 2024
@curquiza curquiza added the enhancement New feature or request label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (aea59d3) to head (c4e85d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   86.51%   86.77%   +0.25%     
==========================================
  Files          10       11       +1     
  Lines        1602     1633      +31     
==========================================
+ Hits         1386     1417      +31     
  Misses        117      117              
  Partials       99       99              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @migueltarga

thanks for your PR 🙏

Can you

  • fix the linter?
  • improve the code coverage please?

Thanks again for your PR, really appreciated. I will create a release once this PR is merged

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
@migueltarga migueltarga requested a review from curquiza July 27, 2024 12:50
@curquiza curquiza changed the title Add New Facet Search Method Add facet search method Jul 29, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuuu

bors merge

Copy link
Contributor

meili-bors bot commented Jul 29, 2024

@meili-bors meili-bors bot merged commit 26be7c8 into meilisearch:main Jul 29, 2024
6 checks passed
@migueltarga
Copy link
Contributor Author

@curquiza Thank you for the approval!

@curquiza
Copy link
Member

I wait for a few days to see if I can merge #544 as well and put it in the same release
If I have no answer I will release on Wednesday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Search in facet values facetSearch
2 participants