-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add facet search method #543
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
+ Coverage 86.51% 86.77% +0.25%
==========================================
Files 10 11 +1
Lines 1602 1633 +31
==========================================
+ Hits 1386 1417 +31
Misses 117 117
Partials 99 99 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @migueltarga
thanks for your PR 🙏
Can you
- fix the linter?
- improve the code coverage please?
Thanks again for your PR, really appreciated. I will create a release once this PR is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank youuuu
bors merge
@curquiza Thank you for the approval! |
I wait for a few days to see if I can merge #544 as well and put it in the same release |
Pull Request
Related issue
Fixes #470
What does this PR do?
Reference: https://www.meilisearch.com/docs/reference/api/facet_search
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!