Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alligned SearchRequest.Vector type to []float32 #524

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

structwafel
Copy link
Contributor

Pull Request

Related issue

Fixes -

What does this PR do?

  • Changes the type of SearchRequest.Vector to a []float32, as it aligns more with meilisearch and general embedding vectors.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@structwafel structwafel changed the title alligned SearchRequest.Vector type to []float32 Alligned SearchRequest.Vector type to []float32 Apr 18, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (cd67941) to head (74246b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files          10       10           
  Lines        1582     1582           
=======================================
  Hits         1321     1321           
  Misses        147      147           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors merge

Copy link
Contributor

meili-bors bot commented Apr 29, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit b601862 into meilisearch:main Apr 29, 2024
6 checks passed
@curquiza curquiza added the enhancement New feature or request label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants