Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vectorSearch (v1.3) #483

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

luigibarbato
Copy link
Contributor

Pull Request

Related issue

Fixes #465

What does this PR do?

  • Add the ability receive a new param in the search request called vector.
  • Add the ability handle a vector key in the response.
  • Add integration tests

PR checklist

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @luigibarbato, for this PR!
The tests are failing because vectorSerach is an experimental feature that needs to be enabled.
I don't recommend that you create the method to activate the experimental functionality but rather make a call to the route with net/http or another package like resty as you wish.
You can see here how the feature and tests have been implemented in python in case it's help

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +37.95% 🎉

Comparison is base (3a6572a) 42.90% compared to head (9bc1fde) 80.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #483       +/-   ##
===========================================
+ Coverage   42.90%   80.85%   +37.95%     
===========================================
  Files          11       10        -1     
  Lines        6832     1901     -4931     
===========================================
- Hits         2931     1537     -1394     
+ Misses       3603      252     -3351     
+ Partials      298      112      -186     
Files Changed Coverage Δ
types.go 0.00% <ø> (ø)
index_search.go 92.50% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luigibarbato luigibarbato marked this pull request as draft September 7, 2023 16:48
@luigibarbato luigibarbato marked this pull request as ready for review September 7, 2023 16:57
@luigibarbato
Copy link
Contributor Author

@alallema there is a problem between easyjson and codecov 😄

@alallema
Copy link
Contributor

@alallema there is a problem between easyjson and codecov 😄

I won't be able to help you with that, @brunoocasali could check that?

@brunoocasali
Copy link
Member

brunoocasali commented Sep 11, 2023

Hi @luigibarbato can you add this file:

# codecov.yml
ignore:
  - "types_easyjson.go" 

@luigibarbato
Copy link
Contributor Author

@alallema @brunoocasali Here we go! 🪂 🥳

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luigibarbato for this PR ❤️
LGTM! 🎉

@alallema
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 12, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit ca77aa0 into meilisearch:main Sep 12, 2023
@curquiza curquiza added the enhancement New feature or request label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] [EXPERIMENTAL] Vector Store
4 participants