-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vectorSearch (v1.3) #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @luigibarbato, for this PR!
The tests are failing because vectorSerach
is an experimental feature that needs to be enabled.
I don't recommend that you create the method to activate the experimental functionality but rather make a call to the route with net/http
or another package like resty as you wish.
You can see here how the feature and tests have been implemented in python in case it's help
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
===========================================
+ Coverage 42.90% 80.85% +37.95%
===========================================
Files 11 10 -1
Lines 6832 1901 -4931
===========================================
- Hits 2931 1537 -1394
+ Misses 3603 252 -3351
+ Partials 298 112 -186
☔ View full report in Codecov by Sentry. |
116835e
to
7b77967
Compare
@alallema there is a problem between |
I won't be able to help you with that, @brunoocasali could check that? |
Hi @luigibarbato can you add this file: # codecov.yml
ignore:
- "types_easyjson.go" |
@alallema @brunoocasali Here we go! 🪂 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luigibarbato for this PR ❤️
LGTM! 🎉
bors merge |
Build succeeded:
|
Pull Request
Related issue
Fixes #465
What does this PR do?
PR checklist