hotfix: only send required parameters for search #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskombro
force-pushed
the
hotfix_send_only_required_search_params
branch
from
5cc1fc0 to
f468478
Compare
curquiza
approved these changes
Jun 4, 2020
eskombro
force-pushed
the
hotfix_send_only_required_search_params
branch
from
f468478 to
af86a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for now, search requests are sending every possible parameter, even those that are unused. For example, searching with a query "term" and a limit of 10 build the following request:
GET /indexes/:indexUid/search?attributesToCrop=&attributesToHighlight=&attributesToRetrieve=&cropLength=0&filters=&limit=10&matches=false&offset=0&q=termThis PR modifies this behavior with a hotfix, as this will be broken with the v0.11. That request would be built as:
GET /indexes/:indexUid/search?limit=10&q=termI call it hotfix because the goal of this PR is to make it compatible as fast as possible, but we might want to find a better and cleaner solution for this