Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nested field support #290

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Conversation

alallema
Copy link
Contributor

Add tests on nested fields to ensure it is still maintained in Meilisearch.

@alallema alallema force-pushed the support-nested-field branch from edf62bf to 78f9a9c Compare April 28, 2022 10:01
},
},
{
name: "TestIndexBasicSearchOnNestedFieldsWithCustomClient",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a custom client?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently use the fasthttp library to create an http client but in go you have the native net/http library to create a client. We offer the possibility for the user to generate his own client with net/http or another library.

index_search_test.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
alallema and others added 2 commits April 28, 2022 14:51
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@alallema alallema requested a review from bidoubiwa April 28, 2022 13:16
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema alallema merged commit d9d08e0 into bump-meilisearch-v0.27.0 Apr 28, 2022
@alallema alallema deleted the support-nested-field branch April 28, 2022 14:18
@alallema alallema added maintenance Anything related to maintenance (CI, tests, refactoring...) enhancement New feature or request and removed maintenance Anything related to maintenance (CI, tests, refactoring...) labels May 2, 2022
bors bot added a commit that referenced this pull request May 9, 2022
286: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#190

This PR:
- gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.27.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #287 
- #289
- #290 
- #291 
- #294
- #293 

# Release
**:warning:** The go package didn't need a version update CI will publish the package once the `Publish release` will be done. However, a version file exists and this is only for analytics but it already is on the next version (the v0.19.1).

This version makes this package compatible with MeiliSearch v0.27.0🎉 
Check out the changelog of [MeiliSearch v0.27.0](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.27.0) for more information about the changes.

## 🚀 Enhancements

* Feature/Analytics (#279) `@brunoocasali`
* Add new methods for the new typo tolerance settings #294 `@alallema`
`Index.GetTypoTolerance()`
`Index.UpdateTypoTolerance(params)`
`Index.ResetTypoTolerance()`
* Ensure nested field support #290 `@alallema`
* Add new search parameters highlightPreTag, highlightPostTag and cropMarker #291 `@alallema`


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants