-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition related to API keys #264
Conversation
561b562
to
a1aee65
Compare
CreatedAt time.Time `json:"createdAt,omitempty"` | ||
UpdatedAt time.Time `json:"updatedAt,omitempty"` | ||
ExpiresAt *string `json:"expiresAt"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is normal that only expiresAt has a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will create an issue about it because there are two structs for handle key: Key
and KeyParsed
.
This one will not be used by the user it just allows me to recreate a Key
with expirationAt
that has the exact ISO-8601 and is a pointer because it could be set at nil
in case you don't want to set and expirationAt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
bors merge |
247: Changes related to the next MeiliSearch release (v0.25.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#157 This PR: - gathers the changes related to the next MeiliSearch release (v0.25.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). - might eventually contain test failures until the MeiliSearch v0.25.0 is out.⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.25.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #254 - #255 - #256 - #257 - #262 - #264 - #265 - #266 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Breaking Changes
Granular management of API keys is now added to MeiliSearch. New methods have been created to manage this:
client.GetKey
get information about a specific API key.client.CreateKey
create a new API key.client.DeleteKey
delete an API key.client.UpdateKey
update an API key.Modification:
client.GetKeys