Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition related to API keys #264

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Addition related to API keys #264

merged 2 commits into from
Feb 3, 2022

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Feb 1, 2022

Breaking Changes

Granular management of API keys is now added to MeiliSearch. New methods have been created to manage this:

  • client.GetKey get information about a specific API key.
  • client.CreateKey create a new API key.
  • client.DeleteKey delete an API key.
  • client.UpdateKey update an API key.

Modification:

  • client.GetKeys

@alallema alallema force-pushed the keys branch 2 times, most recently from 561b562 to a1aee65 Compare February 2, 2022 17:45
@alallema alallema marked this pull request as ready for review February 2, 2022 18:16
Comment on lines +115 to +117
CreatedAt time.Time `json:"createdAt,omitempty"`
UpdatedAt time.Time `json:"updatedAt,omitempty"`
ExpiresAt *string `json:"expiresAt"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is normal that only expiresAt has a string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will create an issue about it because there are two structs for handle key: Key and KeyParsed.
This one will not be used by the user it just allows me to recreate a Key with expirationAt that has the exact ISO-8601 and is a pointer because it could be set at nil in case you don't want to set and expirationAt

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema
Copy link
Contributor Author

alallema commented Feb 3, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

@bors bors bot merged commit bab7833 into bump-meilisearch-v0.25.0 Feb 3, 2022
@bors bors bot deleted the keys branch February 3, 2022 14:41
@alallema alallema added the enhancement New feature or request label Feb 3, 2022
bors bot added a commit that referenced this pull request Feb 8, 2022
247: Changes related to the next MeiliSearch release (v0.25.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#157

This PR:
- gathers the changes related to the next MeiliSearch release (v0.25.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases).
- might eventually contain test failures until the MeiliSearch v0.25.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.25.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #254 
- #255 
- #256 
- #257
- #262 
- #264
- #265 
- #266 

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants