Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MeilisearchApiMessage to MeilisearchApiError #248

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

mmachatschek
Copy link
Contributor

Pull Request

What does this PR do?

Fixes #232

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Dec 10, 2021
@curquiza curquiza requested a review from alallema December 10, 2021 11:27
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥
Thanks for contributing to MeiliSearch @mmachatschek ❤️

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 13, 2021

@bors bors bot merged commit f5c4f8c into meilisearch:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename MeilisearchApiMessage?
3 participants