Convert the dump status to an enum #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
added
skip-changelog
alallema
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Thanks a lot, @roelofjan-elsinga for contributing to Meilisearch ❤️
LGTM! ✨
|
bors merge |
alallema
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps to make the status field more consistent between "Update" and "Dump" and fixes #242.
The UpdateStatus field is an enum, but the DumpStatus field is a string.
In the docs, these fields have a set number of possibilities and that's why it'd be proper to make DumpStatus an enum, rather than a string.