Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new client method for getAllRawIndexes() #208

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Add new client method for getAllRawIndexes() #208

merged 2 commits into from
Oct 11, 2021

Conversation

rizalgowandy
Copy link
Contributor

@rizalgowandy rizalgowandy commented Oct 9, 2021 •
edited
Loading

Issue: #201
Extra: run gofmt for the whole project

@alallema alallema changed the title feat(command): add new client method for get_all_raw_indexes Add new client method for getAllRawIndexes() Oct 11, 2021
alallema
alallema approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @rizalgowandy!
LGTM!

Just one question, do you think it was worth adding gofmt to the IC?

Thank you for contributing to MeiliSearch. If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

@alallema alallema linked an issue Oct 11, 2021 that may be closed by this pull request
Method to get all the indexes should return a list of instance #201
Closed
3 tasks
@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 11, 2021

Build succeeded:

@bors bors bot merged commit c70be2c into meilisearch:main Oct 11, 2021
@rizalgowandy
Copy link
Contributor Author

rizalgowandy commented Oct 11, 2021 •
edited
Loading

Yeah, I think it's still worth it.
I mean it's just a simple gofmt -s -w . command anyway🐧

cc @alallema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method to get all the indexes should return a list of instance
2 participants
@rizalgowandy @alallema